no longer panic upon seeing a moved or treeified bin in treeify_bin #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
|
|
I don't think coverage matters for this change 😅 |
jonhoo
approved these changes
Apr 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the erroneous assumption that attempts to treeify a bin should always be successful and find a regular (linear) bin when loading the bin from the table.
Instead, it is also possible to find a
Movedentry if the bin was moved in the meantime, or aTreeif another thread already treeified the bin before the first thread got to that point.Loading a
TreeNoderemains an error, since these shouldn't be the head of a bin.Closes #83. Refer to this issue or the comment introduced for the above cases with this commit for further explanation.
This change is